You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
This pull request failed to merge because the commit was using the GitHub web interface, and no user was selected. rollerworks/PasswordStrengthValidator#39
Possible Solution
foreach ($commits as $commit) {
if (! isset($commit['author'])) {
$authors['web-flow'] = $authors['commit']['author']['name'] ?? 'web-flow'; // web-flow is the default user for GitHub web edited commits.
} else {
$authors[$commit['author']['login']] = $commit['author']['login'];
}
$message .= $commit['sha'].' '.explode("\n", $commit['commit']['message'], 2)[0]."\n";
}
We can simply use the pr author (not the commit author) if this information is missing 🤷🏼♂️
And actually better to fix this in the GitHub service directly in case this problem appears somewhere else.
This PR was merged into the 1.0-dev branch.
Discussion
----------
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tickets | Fix#90
| License | MIT
Commits
-------
2fec1bb Fix MergeHandler commit with no author info
HubKit version(s) affected: 1.0
Description
This pull request failed to merge because the commit was using the GitHub web interface, and no user was selected.
rollerworks/PasswordStrengthValidator#39
Possible Solution
Additional context
Print-r dump of the commit.
Note. I will try to fix this later today 👍🏼
The text was updated successfully, but these errors were encountered: