Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Remove automatically closing of linked issues #92

Closed
sstok opened this issue Dec 20, 2020 · 1 comment · Fixed by #94
Closed

[RFC] Remove automatically closing of linked issues #92

sstok opened this issue Dec 20, 2020 · 1 comment · Fixed by #94
Labels
BC Break RFC

Comments

@sstok
Copy link
Member

sstok commented Dec 20, 2020

Pull request #59 introduced to the ability to detect and automatically close related issues. In the meantime this feature was added natively to GitHub itself.

I propose to remove this functionality from HubKit and use the GitHub auto detection instead.
@sstok
Copy link
Member Author

sstok commented Dec 22, 2020

As this is last BC breaking change. I'm going to work on this, and then we can finally have a stable 1.0 release 🎉

I have been using this tool for a long time without any major issues.

@sstok sstok mentioned this issue Dec 22, 2020
Merged
@sstok sstok closed this as completed in #94 Dec 22, 2020
sstok added a commit that referenced this issue Dec 22, 2020
@sstok
feature #94 Remove automatically closing of linked issues (sstok)
3964695 
This PR was squashed before being merged into the 1.0-dev branch.
labels: bc-break

Discussion
----------

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tickets       | Closes #92 
| License       | MIT


Commits
-------

b4aa432 [Merge] Remove automatic closing of issues
73a5955 Fix CS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC Break RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove automatically closing of linked issues sstok/hubkit
1 participant
@sstok