Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add question to squash pr during merge #85

Merged
merged 1 commit into from
May 14, 2020

Conversation

acrobat
Copy link
Contributor

@acrobat acrobat commented May 10, 2020

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tickets
License MIT

Sometimes when merging a PR, I forget to pass the --squash option even though the pr has multiple commits and should have been squashed.
So I added an extra question to the merge command to explicitly ask the user if the commits should be squashed in case the --squash was not passed and the pr has multiple commits.

@sstok sstok added the Feature label May 13, 2020
@sstok sstok merged commit 48e1c68 into hupkit:master May 14, 2020
@sstok
Copy link
Member

sstok commented May 14, 2020

Great idea, thanks for your contribution @acrobat

@acrobat acrobat deleted the merge-squash-question branch May 14, 2020 10:37
@acrobat
Copy link
Contributor Author

acrobat commented May 17, 2020

@sstok would it be possible to tag a new release containing this feature? Thanks! 🙌

@sstok
Copy link
Member

sstok commented May 18, 2020

Done 👍

@acrobat
Copy link
Contributor Author

acrobat commented May 18, 2020

Thanks 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants