Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics spanning multiple files #45

Closed
mwalzer opened this issue Sep 20, 2018 · 5 comments
Closed

metrics spanning multiple files #45

mwalzer opened this issue Sep 20, 2018 · 5 comments
Labels

Comments

@mwalzer
Copy link
Collaborator

mwalzer commented Sep 20, 2018

Decide on the way to represent metrics spanning multiple files

related to #35

@mwalzer
Copy link
Collaborator Author

mwalzer commented Sep 20, 2018

@mwalzer
Copy link
Collaborator Author

mwalzer commented Sep 20, 2018

Resolution after discussing on monthly call: go forward with snippet no.2

@mwalzer mwalzer closed this as completed Sep 20, 2018
@bittremieux
Copy link
Collaborator

I didn't include this in my notes about last month's call, but what was the reason to pick option 2 over option 3? Shouldn't we prefer having the unit in there, just like for simple metrics in our examples? (Although the unit for those specific values in the gist probably shouldn't be fraction.)

@mwalzer mwalzer reopened this Oct 25, 2018
@mwalzer
Copy link
Collaborator Author

mwalzer commented Oct 25, 2018

For the sake of keeping it in line with the single file metrics, yes. I have a more detailed example for the call.

@mwalzer
Copy link
Collaborator Author

mwalzer commented Oct 25, 2018

#48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants