Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKNotificationMessage has broken layout #64

Closed
Banck opened this issue Jun 27, 2018 · 8 comments
Closed

EKNotificationMessage has broken layout #64

Banck opened this issue Jun 27, 2018 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@Banck
Copy link

Banck commented Jun 27, 2018

Describe the bug
Seems there is a bug with EKNotificationMessage. See the different from example project with 0.5.1 and your gif example:

from gif example: toasts-48

from demo project: image

Seems the labels should be slightly higher than now.
iPhone (please complete the following information):

  • Device: all
  • iOS Version: all
  • Xcode Version: 9.4.1
  • SwiftEntryKit Release #0.5.1
@huri000
Copy link
Owner

huri000 commented Jun 27, 2018

Seems there is a bug with EKNotificationMessage. See the different from example project with 0.5.1 and your gif example

This is not a bug, it is made by design.
The gif was taken using iPhone X which includes the safe area insets. Correct me if I'm wrong but it seems that you are using smaller screen sized iPhone, thus its insets are lower.

Thanks about the blur notice - I'll look into it. Could you please open another issue that is focused on it and close this one?

@Banck
Copy link
Author

Banck commented Jun 27, 2018

iPhone x:
image
It doesn't look like on the gif. I Think it looks a bit ugly.
But don't know..if it's ok - then ok) I just thought, that name label should be pinned to the beginning of the image

@huri000
Copy link
Owner

huri000 commented Jun 27, 2018

Still, it's not an issue in my opinion.
You can use with EKAttributes's positionConstraints to tune the vertical offset of the view.

@huri000
Copy link
Owner

huri000 commented Jun 27, 2018

I might add a top offset to the content of the message, it should solve your problem.

@huri000 huri000 self-assigned this Jun 27, 2018
@huri000 huri000 added the enhancement New feature or request label Jun 27, 2018
@Banck
Copy link
Author

Banck commented Jun 27, 2018

Ok, but can't I raise the name label by 20 pixels and lower the description by 20 pixels?

@huri000
Copy link
Owner

huri000 commented Jun 27, 2018

Currently, you can't. I'll enable more customizations in the next release.

@Banck
Copy link
Author

Banck commented Jun 27, 2018

So then I should use xib view for that currently. Thanks :-)

Repository owner deleted a comment from Banck Jun 29, 2018
huri000 added a commit that referenced this issue Jun 29, 2018
huri000 added a commit that referenced this issue Jun 29, 2018
@huri000
Copy link
Owner

huri000 commented Jun 29, 2018

A fine tune has been added to your request on 0.5.3. Please see EKNotificationMessage.Insets.

@huri000 huri000 closed this as completed Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants