Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment target is 9.3, not 9.0 #78

Closed
Banck opened this issue Jul 24, 2018 · 3 comments
Closed

Deployment target is 9.3, not 9.0 #78

Banck opened this issue Jul 24, 2018 · 3 comments
Assignees
@huri000
Labels
enhancement New feature or request

Comments

@Banck
Copy link

Banck commented Jul 24, 2018 •
edited

Describe the bug
Hello. The deployment target for SwiftEntryKit is 9.3 from carthage. It should be 9.0.

To Reproduce
Steps to reproduce the behavior:

  1. install SwiftEntryKit through Carthage
    Expected behavior
    Should be 9.0
    Screenshots

iPhone (please complete the following information):

  • Xcode Version 9.4.1
  • Dependency Manager Version : Carthage 0.30.1
  • SwiftEntryKit version: 0.5.6
@huri000
Copy link
Owner

huri000 commented Aug 7, 2018 •
edited

Sorry for the delay, I'll look into it in the next few days and possibly release a new version.

@huri000 huri000 self-assigned this Aug 7, 2018
@huri000 huri000 added the enhancement New feature or request label Aug 7, 2018
huri000 added a commit that referenced this issue Aug 11, 2018
@huri000
Allow lower deployment target: Issue #78 - Deployment target is 9.3, …
6701b93 
…not 9.0.
@huri000 huri000 mentioned this issue Aug 11, 2018
Merged
@huri000
Copy link
Owner

huri000 commented Aug 11, 2018

Resolved in 0.5.7. 🎉

@huri000 huri000 closed this as completed Aug 11, 2018
@Banck
Copy link
Author

Banck commented Aug 11, 2018

Thanks! It works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huri000 huri000

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huri000 @Banck