Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure willDisappear closure is called before removing contentView #86

Merged
merged 1 commit into from Aug 18, 2018
Merged

Ensure willDisappear closure is called before removing contentView #86

merged 1 commit into from Aug 18, 2018

Conversation

apptekstudios
Copy link
Contributor

A very simple fix, solving issue #85.

Issue Link 🔗

Issue #85 - willDisappear closure not called in some cases

Implementation Details ✏️

  • Added calls to lifecycleEvents.willDisappear() in the removePromptly(keepWindow:) and stretchOut(usingSwipe:, duration:) functions of EKContentView

…w (was currently not called if closed via Swipe Gesture)
@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #86 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #86      +/-   ##
=========================================
- Coverage    3.92%   3.91%   -0.01%     
=========================================
  Files          56      56              
  Lines        1986    1991       +5     
=========================================
  Hits           78      78              
- Misses       1908    1913       +5
Impacted Files Coverage Δ
Source/Infra/EKContentView.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad8331a...8487c08. Read the comment docs.

@huri000 huri000 merged commit 1ec36cd into huri000:master Aug 18, 2018
@huri000
Copy link
Owner

huri000 commented Aug 18, 2018

Great, thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants