Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database Shell scripts should respect $DBHOST environment variable #2564

Closed
vorburger opened this issue Oct 8, 2019 · 0 comments · Fixed by #2575
Closed

Database Shell scripts should respect $DBHOST environment variable #2564

vorburger opened this issue Oct 8, 2019 · 0 comments · Fixed by #2575

Comments

@vorburger
Copy link
Contributor

The *.sh scripts under database/ don't seem to respect the DBHOST environment variable, and instead hard-code 127.0.0.1 as the default?

This DBHOST does seem to be used at run-time though, according to app/api/config/database.js; and my PR #2563 proposes to officially document it. Would it therefore make sense to have the DB scripts support it as well out of the box?

This is a similar problem to the older #1592 from @fititnt

This came up in the context of #2559.

@konzz @txau
@vorburger vorburger mentioned this issue Oct 8, 2019
Closed
vorburger added a commit to vorburger/uwazi that referenced this issue Oct 11, 2019
@vorburger
Use (if set) instead 127.0.0.1 in database/*.sh (fixes huridocs#2564)
c3277cb
vorburger added a commit to vorburger/uwazi that referenced this issue Oct 11, 2019
@vorburger
Use $DBHOST (if set) instead 127.0.0.1 in database/*.sh (fixes hurido…
8e71b67 
…cs#2564)
@vorburger vorburger mentioned this issue Oct 11, 2019
Merged
vorburger added a commit to vorburger/uwazi that referenced this issue Oct 11, 2019
@vorburger
Use $DBHOST (if set) instead 127.0.0.1 in database/*.sh (fixes hurido…
cad5b1b 
…cs#2564)
konzz added a commit that referenced this issue Oct 14, 2019
@konzz
Merge pull request #2575 from vorburger/issue-2564_DBHOST
b1774aa 
Use $DBHOST (if set) instead 127.0.0.1 in database/*.sh (fixes #2564)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use $DBHOST (if set) instead 127.0.0.1 in database/*.sh (fixes #2564) vorburger/uwazi
1 participant
@vorburger