-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagination to library #7
Comments
@txau I remember that we discussed about this some time ago, and I'm rescuing a post about Infinite Scrolling vs. Pagination vs. Load more button that can help us to decide which approach is better. https://www.smashingmagazine.com/2016/03/pagination-infinite-scrolling-load-more-buttons/ I'm not a huge fan of Infinite Scrolling because it's annoying to get changes on the UI if you have not requested it. And Pagination breaks the user flow when it's looking for a list of document, because the user loses the references inside other pages. I think Load more button is the better approach to solve our pagination problem. Also if we want to make a "clear state" of pages inside the app, I found an example that can be combined with Load more button: http://codepen.io/SitePoint/pen/XXLrbE What do you think? |
I haven't read the article but I totally agree with the "load more" button strategy. I wouldn't add a clear results button for now. |
I used the loader that we are designing for #30, I think it's useful as a feedback for the user in this context (inside a button): now he knows that something is happening inside the app. @txau you can see the overall flow here: https://github.com/huridocs/uwazi-assets/tree/master/7_load_more_button |
More info about it: https://uxplanet.org/infinite-scrolling-best-practices-c7f24c9af1d#.4mi8w4lik |
A couple of missing pieces:
|
This is inherited from the old design. We can maintain this and just change the second value (1-x) with the number of displayed documents. PD: now you mention it, maybe it's interesting to fix it on the top to don't lose the reference about what are you looking for and how many documents are you reviewing.
I always play with this number because of flexibility when we design columns:
With 12 (or multiple of him) we asure always have the rows with full content, no matter what viewport size we are targeting. This doesn't happen with other numbers (10, 16...)
I think so. I don't mind if it's the dotted icons, a spinner or other loader, but if we use a global loader we give consistency in our interface around de app. We can change it later, because it's an encapsulated component reusable in different context. |
All great @danicatalan , except you just said at #30 that you don't want to introduce the global loader quite yet. And now you are saying that is a good idea. Make up your mind!! =D |
Oh, I havent explained well. I want it right now xD |
I have uploaded the video with all the path for #7 and #30. It's the same loader for both issues, attached at the end of This is the video with the example: https://github.com/huridocs/uwazi-assets/tree/master/30_loading_document |
Am a bit old fashioned, but I like pagination with the option to display On Friday, June 10, 2016, Dani Catalan notifications@github.com wrote:
Daniel D'Esposito |
@danieldesposito that would be great, as long as we can add a selector at the top of the list and we can make it work without pagination. Also, we can add a "Load all documents" button just in case someone wants to view them all. I think we can add this in further sprints as a new story. |
|
LGTM. Moving it to dev. |
No description provided.
The text was updated successfully, but these errors were encountered: