Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6894 - Create ValidatedElement component and sanitized Markdown. #6897

Merged
merged 7 commits into from
Jun 16, 2024

Conversation

RafaPolit
Copy link
Member

fixes #6894

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

Copy link

sentry-io bot commented Jun 13, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/react/Markdown/utils.js

Function Unhandled Issue
logError TypeError: t.includes is not a function find(app/...
Event Count: 1 Affected Users: 11

Did you find this useful? React with a 👍 or 👎

@RafaPolit RafaPolit changed the title Create ValidatedElement component and sanitized Markdown. 6894 - Create ValidatedElement component and sanitized Markdown. Jun 13, 2024
@Zasa-san Zasa-san self-requested a review June 13, 2024 18:02
Copy link
Collaborator

@Zasa-san Zasa-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the complexity of the recursive function is ok. It's readable.

@Zasa-san Zasa-san merged commit f413c00 into development Jun 16, 2024
14 of 15 checks passed
@Zasa-san Zasa-san deleted the 6894-sanitize-html-tags branch June 16, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using malformed HTML can lead to a server error
3 participants