-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced Table component for html table with Inputs #7041
Conversation
…6675-translations-bug
The issue of the focus is fixed but there's a slight problem with filtering by untranslated terms: You can see that when filtering and unfiltering |
@@ -1,3 +1,5 @@ | |||
/* eslint-disable react/jsx-props-no-spreading */ | |||
/* eslint-disable react/no-multi-comp */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rule disable can be removed
hideLabel | ||
disabled={submitting} | ||
clearFieldAction={reset} | ||
errorMessage={hasErrors ? <Translate>This field is required</Translate> : ''} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By replacing this with the standard form input the This field is required
message is not longer shown. Not a big deal but the error state for the new field is not that obvious, the border is not as red when it's not focused. In a long list an error might go unnoticed without this message.
…o 6675-translations-bug
fixes #6675
PR checklist:
QA checklist: