Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Table component for html table with Inputs #7041

Merged
merged 11 commits into from
Jul 26, 2024

Conversation

konzz
Copy link
Member

@konzz konzz commented Jul 24, 2024

fixes #6675

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

@konzz konzz self-assigned this Jul 26, 2024
@konzz konzz changed the title Replaced Tamble component for html table with Inputs Replaced Table component for html table with Inputs Jul 26, 2024
@konzz konzz requested a review from Zasa-san July 26, 2024 10:29
@Zasa-san
Copy link
Collaborator

The issue of the focus is fixed but there's a slight problem with filtering by untranslated terms:
translationserror.webm

You can see that when filtering and unfiltering Item 1 translation values are not shown correctly. Scrolling down to remove Item 1 from view seems to fix this. But it could be a problem when saving if those values are incorrect.

@@ -1,3 +1,5 @@
/* eslint-disable react/jsx-props-no-spreading */
/* eslint-disable react/no-multi-comp */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule disable can be removed

hideLabel
disabled={submitting}
clearFieldAction={reset}
errorMessage={hasErrors ? <Translate>This field is required</Translate> : ''}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By replacing this with the standard form input the This field is required message is not longer shown. Not a big deal but the error state for the new field is not that obvious, the border is not as red when it's not focused. In a long list an error might go unnoticed without this message.

@konzz konzz merged commit 8357473 into development Jul 26, 2024
19 checks passed
@konzz konzz deleted the 6675-translations-bug branch July 26, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input fields in Translations are loosing focus when start typing in them
2 participants