Removal of delimiters and support for partials #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added options for partial and helper registration Removed delimiters (seems like a bug in the package; not all expressions were evaluated)
|
Mind resolving the merge conflict? |
|
Ofcourse, will do so end of the day! |
|
Adam, Could you girant me write permissions on the repo so I can merge conflicts? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The handlebars delimiters resulted in unexpected behavior after testing with more complex handlebar templates. Therefore I have removed this functionality.
I also added Handlebars partial support. For now it is a single directory, but we could easily extend this with a glob with a particular file extension (ie, */.hbs).
Also, tests for partials have not been written yet..
Cheers,
Michael