Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite and adding features #1

Merged
merged 22 commits into from
Nov 5, 2023
Merged

Rewrite and adding features #1

merged 22 commits into from
Nov 5, 2023

Conversation

husjon
Copy link
Owner

@husjon husjon commented Nov 5, 2023

Rewritten most of the cleaner functionality.

  • Added support for user customizable file extensions that should be cleaned up.
    Defaulted to empty list.
  • Added support for deletion confirmation showing list of files to delete with clickable links.
    image
  • Updated localizations
  • Updated settings
    image
  • Added button in settings to reset configuration of the plugin with confirmation
    image

@husjon
formatted with prettier
9b8ec88
@husjon
removed unused imports
2f10af8
@husjon
replaced let with const where applicable
69f2d8a
@husjon
created locale definitions
3877772
@husjon
replaced translations with new locale definitions
0a15e43
@husjon
updated settings header size
a9de96e
@husjon
Added ability to reset settings back to default
1c0fa8e
@husjon
added placeholder values to inputs
90c4941
@husjon
adjusted translations
ac97df4
@husjon
set default size of textarea
75d8e84
@husjon
made excludedFolders a list of strings
498c15d
@husjon
changed deletionDestination to use enum
e1ff46d
@husjon
added setting for deleting orphaned attachments
7057125
@husjon
list of extensions are now without the period prefix
9e6ecaa
@husjon
created helper function for file deletion
9967944
@husjon
simplified cleanup function
80433c3
@husjon
renamed cleanup function
afcb05e
@husjon
fixed allowedExtensions regex
a8c18e0
@husjon
extracted modal to separate helper file
4f54bd6
@husjon
removed some comments
3bc3ad0
@husjon
added Confirmation for deletion
ff1a535
@husjon
simplified structure for modal texts
06d2f5b
@husjon husjon merged commit 8720669 into main Nov 5, 2023
@husjon husjon mentioned this pull request Nov 6, 2023
Open
@husjon
Copy link
Owner Author

husjon commented Nov 6, 2023

Fixes Johnson0907/obsidian-file-cleaner#7
Fixes Johnson0907/obsidian-file-cleaner#13
Fixes Johnson0907/obsidian-file-cleaner#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@husjon