Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #3

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Fix CI #3

merged 1 commit into from
Sep 27, 2019

Conversation

647-coder
Copy link

No description provided.

@647-coder
Copy link
Author

ready for review

setup.py Outdated
@@ -7,7 +7,7 @@
install_requires = [
"SQLAlchemy>=0.9.0,<1.1.0",
"blinker>=1.3,<2.0",
"mysql-replication>=0.5,<0.6.0",
"mysql-replication>=0.5",
Copy link
Member

@mozillazg mozillazg Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个修改是必须的吗 ❓

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

降了 PyMySQL 版本,没问题了。

Copy link
Member

@mozillazg mozillazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setup.py 那个修改是必须的不?

@mozillazg
Copy link
Member

其他 LGTM.

@mowangdk
Copy link
Member

LGTM

Copy link
Member

@mozillazg mozillazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mozillazg mozillazg merged commit 97b1b07 into huskar-org:version_0.2 Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants