Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal code quality issue while running on CI/CD pipeline #4

Closed
surajvantage opened this issue Jan 31, 2022 · 1 comment · Fixed by #5
Closed

Drupal code quality issue while running on CI/CD pipeline #4

surajvantage opened this issue Jan 31, 2022 · 1 comment · Fixed by #5

Comments

@surajvantage
Copy link

surajvantage commented Jan 31, 2022

When I raise a PR with the develop branch in GitHub, drupal_code_quality check is facing while running on CI/CD pipeline.
Below is a reference for the issue:

Running phpcs --standard=phpcs.xml --extensions=php,module,inc,install,test,profile,theme --ignore=/node_modules/ docroot/modules/custom

  /usr/bin/docker run --workdir /home/runner/work/glt/glt --rm --init --tty -v /var/run/docker.sock:/var/run/docker.sock -v /home/runner/work/glt/glt:/home/runner/work/glt/glt hussainweb/drupalqa:php7.4 phpcs --standard=phpcs.xml --extensions=php,module,inc,install,test,profile,theme --ignore=/node_modules/ docroot/modules/custom

  ERROR: Referenced sniff "SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator" does not exist

  Run "phpcs --help" for usage information

  Error: drupalqa: The process '/usr/bin/docker' failed with exit code 3
@surajvantage surajvantage changed the title Drupal code quality issue with CI/CD pipeline Drupal code quality issue while running on CI/CD pipeline Jan 31, 2022
@hussainweb
Copy link
Owner

Thanks, @surajvantage for reporting this. This is due to the new dependency added to the coder module (which contains the Drupal and DrupalPractice sniffs). See pfrenssen/coder#147. The dependency does get included but phpcs doesn't know about the path. We should fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants