Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DOMMatrix): add toFloat32Array and toFloat64Array #70

Merged
merged 2 commits into from Sep 29, 2020
Merged

feat(DOMMatrix): add toFloat32Array and toFloat64Array #70

merged 2 commits into from Sep 29, 2020

Conversation

FeliciousX
Copy link
Contributor

Description

Add 2 methods that DOMMatrix has but is missing in the mock

  • toFloat32Array()
  • toFloat64Array()

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6f0d771 on FeliciousX:dommatrix into df7a9fb on hustcc:master.

jtenner
jtenner approved these changes Aug 5, 2020
View reviewed changes
Copy link
Collaborator

@jtenner jtenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hustcc hustcc merged commit 340de22 into hustcc:master Sep 29, 2020
@hustcc
Copy link
Owner

hustcc commented Sep 29, 2020 •
edited

Thanks for contribute. v2.3.0 released, and you are added into contributor list.

@FeliciousX FeliciousX deleted the dommatrix branch October 8, 2020 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtenner jtenner jtenner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FeliciousX @coveralls @hustcc @jtenner