-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure to allow usage without built-in locales #205
Conversation
Pull Request Test Coverage Report for Build 481
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally, can you help to show the package size increment?
@hustcc how can I see the package size increment? do you mean the size of the resulting bundles? I don't think the size actually changes but it'd be happy to check if you let me know what package size I need to look at and how. |
Output of
|
Same before the change:
|
v4.0.1 released. |
I am proposing a change to address the issue #204:
The only difference to the plan outlined here #204 (comment) is that I think
core.ts
would redundant. Instead it's more flexible if every method is separate. I'd use it like this:so that realtime.ts and built-in locales can be stripped from my bundle.
What do you think?