Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more translations #5

Closed
wants to merge 1 commit into from
Closed

Add more translations #5

wants to merge 1 commit into from

Conversation

shaneog
Copy link
Contributor

@shaneog shaneog commented Sep 2, 2016

I love this little library - but I need more translations, so I'm going to add them in this PR 😄
This is built on top of #4.

  • Brazilian Portuguese (pt_BR)
  • Dutch (nl)
  • Spanish (es)
  • French (fr)
  • Italian (it)
  • German (de)

@hustcc
Copy link
Owner

hustcc commented Sep 5, 2016

Use register to load locales, and locale translation added into locales dir maybe best way to keep this lib tiny.

This lib now is 2.5kb, more big then before 1.9kb.

jQuery.timeago's locales is also like this…

so put the pr's locale translation into locales dir, and name the translation file with the locale key + .js .

Very thanks ^^_

@shaneog
Copy link
Contributor Author

shaneog commented Sep 5, 2016

@hustcc Ok, I'll do that.

hustcc pushed a commit that referenced this pull request Sep 7, 2016
@connorshea
Copy link

@shaneog see latest commits to master, the locale file format was updated. Also, it may be easier if this was split into a PR for each language?

@shaneog
Copy link
Contributor Author

shaneog commented Sep 11, 2016

Wow. Looks like everyone else has beaten me to it ;)

@shaneog shaneog closed this Sep 11, 2016
@shaneog shaneog deleted the add-translations branch September 11, 2016 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants