Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve gamepad interaction with listviews #288

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

United600
Copy link
Collaborator

No description provided.

@United600 United600 added the a11y Issues with navigation interactions, screen readers, contrast, text sizes and other areas label Jan 3, 2024
<Style x:Key="ListViewItemFocusEngagementStyle" TargetType="ListViewItem">
<Style
x:Key="ListViewItemFocusEngagementStyle"
BasedOn="{StaticResource DefaultListViewItemStyle}"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This style needs to be based on the default ListViewItem style from WinUI to not break the default styling.

@huynhsontung huynhsontung merged commit a6252b7 into huynhsontung:main Jan 13, 2024
4 checks passed
@United600 United600 deleted the focus-listview branch January 14, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues with navigation interactions, screen readers, contrast, text sizes and other areas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants