Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: media track improvements #353

Merged
merged 10 commits into from
Apr 12, 2024
Merged

feat: media track improvements #353

merged 10 commits into from
Apr 12, 2024

Conversation

huynhsontung
Copy link
Owner

@huynhsontung huynhsontung commented Apr 8, 2024 •
edited

  • Support .idx and .sub files
  • Use proper neighbouring files query to find subtitles in the current directory.
  • Improve external subtitle handling, including auto subtitle load on playback. Fixes auto load subtitle file which has the same name as the video? #190
  • Unify video, audio, and subtitle track to have the same base class MediaTrack
  • Parse language tag to display language name whenever possible. Fixes Captions are buggy #235
  • Show a tool tip if the subtitle name is too long

@huynhsontung huynhsontung changed the title feat: improve auto subtitle load in the same directory feat: media track improvements Apr 12, 2024
@huynhsontung huynhsontung marked this pull request as ready for review April 12, 2024 05:40
@huynhsontung huynhsontung merged commit e93a170 into main Apr 12, 2024
4 checks passed
@huynhsontung huynhsontung deleted the better-sub branch April 12, 2024 05:44
@huynhsontung huynhsontung mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Captions are buggy auto load subtitle file which has the same name as the video?
1 participant
@huynhsontung