Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.auth.ldap.configure params doesn't match client.auth.ldap.read_configuration #974

Closed
ceesios opened this issue Apr 12, 2023 · 1 comment · Fixed by #975
Closed
Assignees
Labels
auth methods generally related to a Vault auth method ldap ldap auth method

Comments

@ceesios
Copy link
Contributor

ceesios commented Apr 12, 2023

Configure is missing a couple of params;
- anonymous_group_search
- request_timeout
- token_bound_cidrs
- token_explicit_max_ttl
- token_no_default_policy
- token_num_uses
- token_period
- token_policies
- token_type
- use_pre111_group_cn_behavior
- userfilter
- username_as_alias #917

Also some parameters differ in their naming from the values returned by the vault api and read_configuration;

  • user_dn = userdn
  • group_dn = groupdn
  • bind_dn = binddn
  • bind_pass=bindpass
  • user_attr = userattr
  • discover_dn = discoverdn
  • upn_domain = upndomain
  • group_filter = groupfilter
  • group_attr = groupattr

Would it be a good idea to add all missing parameters? And to add the parameters by their names as in the vault api, keeping the names with underscores for backwards compatibility?

ceesios added a commit to ceesios/ansible-modules-hashivault that referenced this issue Apr 12, 2023
@briantist briantist self-assigned this Apr 12, 2023
@jlixfeld
Copy link

What amazing timing! I just ran up against not being able to pass some LDAP parameters to HVAC that were in the API and found this.

Thanks for your work. Looking forward to when this is merged.

@briantist briantist added auth methods generally related to a Vault auth method ldap ldap auth method labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth methods generally related to a Vault auth method ldap ldap auth method
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants