-
Notifications
You must be signed in to change notification settings - Fork 393
expand Vault CI matrix, announce deprecation of Vault dynamic SSH keys #1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tyler Hess <tylerlhess@gmail.com>
79e0a00
to
2e079c3
Compare
Codecov Report
@@ Coverage Diff @@
## main #1023 +/- ##
=======================================
Coverage 84.70% 84.70%
=======================================
Files 65 65
Lines 3066 3066
=======================================
Hits 2597 2597
Misses 469 469
|
adammike
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great, Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/CD
related to CI/CD (not necessarily tests)
deprecation
Deprecates something, to be removed or changed in a later release
secrets engines
generally related to a Vault secrets engine
ssh
SSH secrets engine
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vault Dynamic SSH Keys
This feature was deprecated in Vault and was removed in Vault 1.13.0. Although we have not decided a version for removal yet, the support for it in
hvac
will be removed at some point; likely at the same time we decide to drop support for older versions of Vault.Once we have a decision and timeline for supported versions of Vault, a more specific announcement can be made.
Thanks to @Tylerlhess for pointing out that our Vault integration matrix is quite a bit behind.
In this PR I'm attempting to expand it.
I will also look at expanding the enterprise versions, since those are really old...Using newer enterprise versions is a more complicated matter which I'll try to address in a different PR.