Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand Vault CI matrix, announce deprecation of Vault dynamic SSH keys #1023

Merged
merged 15 commits into from Jul 3, 2023

Conversation

briantist
Copy link
Contributor

@briantist briantist commented Jul 2, 2023

Vault Dynamic SSH Keys

This feature was deprecated in Vault and was removed in Vault 1.13.0. Although we have not decided a version for removal yet, the support for it in hvac will be removed at some point; likely at the same time we decide to drop support for older versions of Vault.

Once we have a decision and timeline for supported versions of Vault, a more specific announcement can be made.


Thanks to @Tylerlhess for pointing out that our Vault integration matrix is quite a bit behind.

In this PR I'm attempting to expand it.

  • use a wildcard for the patch version component
  • adding 1.12.x-1.14x
  • turns off fail-fast on lint, unit, and integration tests (we want to know if failures only exist in a certain combination)
  • turn on colorized output for pytest in CI
  • fixing breakages due to backports of changes into new minor versions
  • skipping SSH tests for features removed in later Vault versions
  • some minor coverage changes following on the heels of update coverage report locations, remove duplicate filenames #1024

I will also look at expanding the enterprise versions, since those are really old...
Using newer enterprise versions is a more complicated matter which I'll try to address in a different PR.

@briantist briantist added CI/CD related to CI/CD (not necessarily tests) misc Used as a release-drafter "category" labels Jul 2, 2023
@briantist briantist self-assigned this Jul 2, 2023
@briantist briantist changed the title CI: expand Vault matrix expand Vault CI matrix, announce deprecation of Vault dynamic SSH keys Jul 2, 2023
@briantist briantist added deprecation Deprecates something, to be removed or changed in a later release and removed misc Used as a release-drafter "category" labels Jul 2, 2023
@briantist briantist added this to the 1.2.0 milestone Jul 2, 2023
@briantist briantist marked this pull request as ready for review July 2, 2023 19:49
@briantist briantist requested a review from a team as a code owner July 2, 2023 19:49
@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #1023 (5d3ba59) into main (ab541ac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1023   +/-   ##
=======================================
  Coverage   84.70%   84.70%           
=======================================
  Files          65       65           
  Lines        3066     3066           
=======================================
  Hits         2597     2597           
  Misses        469      469           
Impacted Files Coverage Δ
hvac/api/secrets_engines/ssh.py 96.72% <ø> (ø)

Copy link
Member

@adammike adammike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great, Thanks!

@briantist briantist merged commit d5eabd5 into hvac:main Jul 3, 2023
38 checks passed
@briantist briantist deleted the ci/vault-version-matrix branch July 3, 2023 17:16
@briantist briantist added secrets engines generally related to a Vault secrets engine ssh SSH secrets engine labels Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD related to CI/CD (not necessarily tests) deprecation Deprecates something, to be removed or changed in a later release secrets engines generally related to a Vault secrets engine ssh SSH secrets engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants