Fix raise_on_deleted_version warning #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning mentioned the "raise_on_deleted" parameter, where the parameter is actually "raise_on_deleted_version"
briantist
added
bug
secrets engines
Codecov Report
@@ Coverage Diff @@
## main #1045 +/- ##
=======================================
Coverage 85.00% 85.00%
=======================================
Files 65 65
Lines 3135 3135
=======================================
Hits 2665 2665
Misses 470 470
|
briantist
approved these changes
Sep 9, 2023
|
@iTrooz thanks for noticing this and putting in the fix, this is live in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning mentioned the "raise_on_deleted" parameter, where the parameter is actually "raise_on_deleted_version"
Fixes an issue raised in #955