Make plaintext and ciphertext optional for batch operations
#1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantist
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #1049 +/- ##
==========================================
+ Coverage 85.00% 85.02% +0.01%
==========================================
Files 65 65
Lines 3135 3139 +4
==========================================
+ Hits 2665 2669 +4
Misses 470 470
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
briantist
reviewed
Sep 10, 2023
The Vault API requires setting `plaintext` and `ciphertext` for the encrypt and decrypt API, even though they are ignored when `batch_input` is set. This means that end users have to include an empty argument when doing batch operations, which is a bit annoying.
dosisod
force-pushed
the
cleanup-batch-input
branch
from
5adc496
to
71b49d2
Compare
briantist
approved these changes
Sep 10, 2023
There was a problem hiding this comment.
Looks great, thanks again @dosisod ! We're actively looking for contributors so if you're interested please don't be a stranger :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Vault API requires setting
plaintextandciphertextfor the encrypt/decrypt data API, even though the fields are ignored whenbatch_inputis set. This means that end users have to include an empty argument when doing batch operations, which is a bit annoying.While this works, it might be more ergonomic to have an
encrypt_dataand abatch_encrypt_datafunction as most of theencrypt_dataargs are ignored in batch mode anyways, which could potentially lead to bugs. This is a bit out of scope for this PR, just thought I would mention it here as an alternative.Also, I could not test locally due to self-signed certificate errors. Is there a certificate I need to install for testing?