Remove old deprecated client attributes
#1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantist
added
breaking-change
major
Codecov Report
@@ Coverage Diff @@
## main #1062 +/- ##
==========================================
+ Coverage 86.19% 86.26% +0.07%
==========================================
Files 64 64
Lines 3107 3101 -6
==========================================
- Hits 2678 2675 -3
+ Misses 429 426 -3
|
kaypeter87
approved these changes
Sep 20, 2023
briantist
force-pushed
the
remove/old-deprecations
branch
from
3978f13
to
b1b3960
Compare
|
Thanks for another helpful review @kaypeter87 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #549
Several attributes that were marked deprecated years ago are finally being removed. They were originally planned to be removed in
v0.9.0.The affected attributes and their replacements are:
client.github -> client.auth.githubclient.ldap -> client.auth.ldapclient.kv -> client.secrets.kvclient.auth: this one was marked to useadapters.Request.loginas a replacement method, butadapters.Requestis an old name that's kept working for backward compatibility. Instead, choose a specific adapter, likeadapter.JSONAdapter().login.