Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python-jwt dev dependency #1084

Merged
merged 2 commits into from Oct 14, 2023

Conversation

briantist
Copy link
Contributor

@briantist briantist commented Oct 14, 2023

Resolves #766

The python-jwt package referenced in our dev requirements is not actually used directly. However, we were relying on the jwcrypto package which was being installed by way of python-jwt. The former is now added as an explicit dependency and the latter is removed.

No functional changes in this PR.

@briantist briantist added dependencies Pull requests that update a dependency file misc Used as a release-drafter "category" labels Oct 14, 2023
@briantist briantist added this to the 2.0.0 milestone Oct 14, 2023
@briantist briantist self-assigned this Oct 14, 2023
@briantist briantist requested a review from a team as a code owner October 14, 2023 17:04
@briantist briantist added the tests related to tests (not necessarily CI/CD) label Oct 14, 2023
@briantist briantist merged commit 6da4ab3 into hvac:main Oct 14, 2023
33 checks passed
@briantist briantist deleted the dependencies/drop-python-jwt branch October 14, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file misc Used as a release-drafter "category" tests related to tests (not necessarily CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stale python-jwt requirement?
1 participant