Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vault 1.15.x to integration tests #1103

Merged
merged 1 commit into from Oct 29, 2023
Merged

Add Vault 1.15.x to integration tests #1103

merged 1 commit into from Oct 29, 2023

Conversation

tot19
Copy link
Contributor

@tot19 tot19 commented Oct 28, 2023 •
edited by briantist

Looks like the requirement to have a valid JWT token was removed in version 1.15.0 based on this pull request. Disabled the jwt error parameter (number 4) for versions 1.15.0 and greater.

Resolves #1075

@tot19 tot19 requested a review from a team as a code owner October 28, 2023 14:35
@tot19
Copy link
Contributor Author

tot19 commented Oct 28, 2023

#1075

@briantist briantist self-assigned this Oct 29, 2023
@briantist briantist added auth methods generally related to a Vault auth method CI/CD related to CI/CD (not necessarily tests) kubernetes Kubernetes auth method misc Used as a release-drafter "category" patch Used as part of release-drafter's version-resolver configuration tests related to tests (not necessarily CI/CD) labels Oct 29, 2023
@codecov
Copy link

codecov bot commented Oct 29, 2023 •
edited

Codecov Report

Merging #1103 (9401ee3) into main (9161044) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1103   +/-   ##
=======================================
  Coverage   87.09%   87.09%           
=======================================
  Files          64       64           
  Lines        3146     3146           
=======================================
  Hits         2740     2740           
  Misses        406      406

briantist
briantist approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this and helping to expand our CI coverage!

@briantist briantist merged commit f57cc04 into hvac:main Oct 29, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briantist briantist briantist approved these changes

Assignees

@briantist briantist

Labels
auth methods generally related to a Vault auth method CI/CD related to CI/CD (not necessarily tests) kubernetes Kubernetes auth method misc Used as a release-drafter "category" patch Used as part of release-drafter's version-resolver configuration tests related to tests (not necessarily CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Vault 1.15.x to integration tests
2 participants
@tot19 @briantist