New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Add HTTP/2+ use case into the advanced usage section #1111
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1111 +/- ##
=======================================
Coverage 87.38% 87.38%
=======================================
Files 66 66
Lines 3227 3227
=======================================
Hits 2820 2820
Misses 407 407 |
Hello again, FYI you could be potentially interested in knowing that the newest release of Niquests support secure/encrypted DNS with DNSSEC, amongst other things. import niquests
s = niquests.Session(resolver="doh+google://", multiplexed=True)
... Do you want a note in the docs about it? |
Sure feel free to add that to this PR! |
Niquests is a drop-in replacement for Requests that offer an escape hatch for hvac user that desire to leverage recent HTTP capabilities.
This reverts commit 964aecc.
Ok! So, I created a whole new top-level section for user-contributed use cases like these, and yours will be the first. I loved your doc into there. I made some other minor changes:
If you'd like to tweak any the wording or the links, please go ahead. I chose your project's "issues" link as the "support" link but if there's a better place, please update the link. There's only one other tweak I'd like to ask you to do, and that's change the multiplexing code sample to not have to scroll horizontally, if possible. Maybe it's only on my screen? Not sure, please take a look when you can. You can render the documentation locally by following the instructions in the contributor guide (use some of the steps added in this PR 😅). One other request: unless you really need or want to, please do not squash commits locally. We squash-and-merge all of our PRs so the individual commits won't matter on the merge. Squashing locally makes it a little harder for me to review; I'd rather be able to see the individual changes, especially as PR development goes on. If you must squash locally, the PR will still be reviewed it just may take longer :) |
I am okay with your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks so much for this contribution @Ousret !
That PR addresses a question from the community regarding the evolution of the HTTP backend. Still, It's a workaround, but it's a start.
Niquests is a drop-in replacement for Requests that offers an escape hatch for hvac users who desire to leverage recent HTTP capabilities. The documentation now showcases two workarounds for the limitations imposed by Requests.
Linked to #807 (comment)
This alternative HTTP backend brings a lot of enhancement, I am sure that we'll find some synergies.