Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try not skipping on cache hit #1121

Merged
merged 2 commits into from Dec 30, 2023
Merged

try not skipping on cache hit #1121

merged 2 commits into from Dec 30, 2023

Conversation

briantist
Copy link
Contributor

Since #1119 , I've noticed that doctests run are failing, unable to find sphinx-build, unless I delete the cache and let it reinstall the dependencies. I guess the caching mechanism is not keeping the bin type files so the command sphinx-build just doesn't exist?

Trying to fix without completely uncaching...

@briantist briantist added documentation documentation updates and/or requests for expanded documentation CI/CD related to CI/CD (not necessarily tests) patch Used as part of release-drafter's version-resolver configuration labels Dec 30, 2023
@briantist briantist self-assigned this Dec 30, 2023
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (27dad5b) 87.12% compared to head (c8b90df) 87.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1121   +/-   ##
=======================================
  Coverage   87.12%   87.12%           
=======================================
  Files          64       64           
  Lines        3162     3162           
=======================================
  Hits         2755     2755           
  Misses        407      407           

@briantist briantist marked this pull request as ready for review December 30, 2023 21:57
@briantist briantist requested a review from a team as a code owner December 30, 2023 21:57
@briantist
Copy link
Contributor Author

Seems to work! https://github.com/hvac/hvac/actions/runs/7366531054/job/20048899106?pr=1121#step:4:38

The first run did not find the cache, then I re-ran the docs job and it did find the cache. Running the install step again still had to install packages but not all of them, and it only took around 5 seconds.

The reason this is happening is because all the other runs don't install the docs group, so if another run populated the cache, then when it gets restored in this run, it does not include docs deps.

There's a possibility that in some workflow run, this job would be the first to populate a cache, and then the other jobs would all be restoring a cache that includes docs dependencies, but that is not any kind of problem.


Merging since this has no user-facing changes.

@briantist briantist added skip-changelog will not be shown in the auto-generated changelog and removed patch Used as part of release-drafter's version-resolver configuration labels Dec 30, 2023
@briantist briantist merged commit 6fcd885 into hvac:main Dec 30, 2023
35 checks passed
@briantist briantist deleted the docs/ci-cache branch December 30, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD related to CI/CD (not necessarily tests) documentation documentation updates and/or requests for expanded documentation skip-changelog will not be shown in the auto-generated changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant