Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace distutils.spawn with shutil.which #1146

Merged
merged 4 commits into from Mar 24, 2024
Merged

Replace distutils.spawn with shutil.which #1146

merged 4 commits into from Mar 24, 2024

Conversation

loqs
Copy link
Contributor

@loqs loqs commented Mar 23, 2024

distutils was removed in python 3.12.
Closes #1142

@loqs
Replace distutils.spawn with shutil.which
37ad2f6 
distutils was removed in python 3.12.
Closes hvac#1142
@loqs loqs requested a review from a team as a code owner March 23, 2024 21:35
@briantist briantist self-assigned this Mar 24, 2024
@briantist briantist added dependencies Pull requests that update a dependency file patch Used as part of release-drafter's version-resolver configuration maintenance General technical debt developer experience Developer setup and experience labels Mar 24, 2024
@briantist briantist added this to the 2.2.0 milestone Mar 24, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 24, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.66%. Comparing base (19ad4f5) to head (f411950).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1146   +/-   ##
=======================================
  Coverage   87.66%   87.66%           
=======================================
  Files          66       66           
  Lines        3227     3227           
=======================================
  Hits         2829     2829           
  Misses        398      398

see 1 file with indirect coverage changes

briantist
briantist approved these changes Mar 24, 2024
View reviewed changes
Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for putting this up @loqs !

@briantist briantist merged commit 48027db into hvac:main Mar 24, 2024
35 checks passed
@briantist briantist added tests related to tests (not necessarily CI/CD) misc Used as a release-drafter "category" labels Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briantist briantist briantist approved these changes

Assignees

@briantist briantist

Labels
dependencies Pull requests that update a dependency file developer experience Developer setup and experience maintenance General technical debt misc Used as a release-drafter "category" patch Used as part of release-drafter's version-resolver configuration tests related to tests (not necessarily CI/CD)
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

Some tests use distutils module that has been removed in python 3.12
2 participants
@loqs @briantist