Customizable approle path / mount_point #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bartwalczak1: This PR is meant to address your issue. I would appreciate your sign-off in the comments here as to whether it does that successfully or not. :D |
|
looks good thanks! |
jeffwecan
force-pushed
the
jeffwecan/issue_178_approle_mount_paths
branch
from
b096d8e
to
a8c4a16
Compare
|
Noting for posterity: I added some unit tests for all the methods being changed here to ensure there were tests covering the specific changes (which ended up being good because I caught one potential bug while adding em!). As a result of that, I updated any approle methods that returned None to instead return their associated Vault response. That was needed for the test assertions but also provided additional information to the methods' callers if they desire it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves for #178.
Auth backends can be mounted under arbitrary paths. This PR ensures custom paths can be used with the module and the approle auth backend in particular.