Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#376 : fix length in transit.generate_random_bytes() #377

Merged

Conversation

kserrano
Copy link
Contributor

@kserrano kserrano commented Jan 9, 2019

The parameter in the HTTP request was incorrect according to the
latest vault API
https://www.vaultproject.io/api/secret/transit/index.html

The parameter in the HTTP request was incorrect according to the
latest vault API
https://www.vaultproject.io/api/secret/transit/index.html
@jeffwecan jeffwecan added this to the 0.7.3 milestone Jan 9, 2019
@jeffwecan
Copy link
Member

I have a feeling the parameter name may have changed recently then...

@kserrano: Would you mind trying to add some regression tests for the issue you lodged as part of this PR? Having such test(s) would allow our travis-ci builds to verify this change is safe for the various versions of Vault the hvac module supports.

@jeffwecan jeffwecan added the transit Transit secrets engine label Jan 9, 2019
@kserrano
Copy link
Contributor Author

Alright, will do. My change is breaking compatibility with vault versions using the old parameter name 'n_bytes'. I don't know when they changed it.

@jeffwecan
Copy link
Member

Yup, that is a common issue with this module + maintaining support for the generally recent releases of Vault. I'll see about taking a go at adding some test cases that confirm which versions we would be concerned with in this context as a first step. Assuming the change from n_bytes to bytes happened within our support span of Vault releases, we might have to see about making accommodations (one way or another) to support both forms of the parameters until hvac drops support for the Vault versions that would require a parameter name of n_bytes...

@jeffwecan jeffwecan self-assigned this Jan 18, 2019
Copy link
Member

@jeffwecan jeffwecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transit Transit secrets engine
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants