Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes to database secrets engine #457

Merged
merged 6 commits into from Jun 3, 2019
Merged

Conversation

drewmullen
Copy link
Member

@drewmullen drewmullen commented May 31, 2019

fix delete_connection return value. call does not return json object

include optional mount_point but default to 'database'

tested:
list_connections
read_connection
configure
delete_connection
create_role
delete_role
list_roles

include mount_point doc

flake8
@codecov-io
Copy link

codecov-io commented May 31, 2019

Codecov Report

Merging #457 into develop will increase coverage by <.01%.
The diff coverage is 47.61%.

@@            Coverage Diff            @@
##           develop   #457      +/-   ##
=========================================
+ Coverage       88%    88%   +<.01%     
=========================================
  Files           50     50              
  Lines         2659   2660       +1     
=========================================
+ Hits          2340   2341       +1     
  Misses         319    319
Impacted Files Coverage Δ
hvac/api/secrets_engines/database.py 37.5% <47.61%> (+1.6%) ⬆️

@drewmullen
Copy link
Member Author

@jeffwecan alright so afaik these are good to go. ive tested most of the functionality and am using them here: TerryHowe/ansible-modules-hashivault#133

if you have a chance to merge and cut a release next week that would be AWESOME!

@drewmullen drewmullen changed the title fix delete_con and include mount_point var fixes to database secrets engine May 31, 2019
@jeffwecan jeffwecan added this to the 0.9.2 milestone Jun 3, 2019
@jeffwecan
Copy link
Member

Sounds good, thanks again for all the contributions! I'll aim to cut a release over the next few days as I have time available.

@jeffwecan jeffwecan merged commit fa529b7 into hvac:develop Jun 3, 2019
@drewmullen
Copy link
Member Author

Absolutely. I'm looking at your unit tests trying to see if i can figure out a way to make some for this module also... havent messed with mocks much so might take me sometime but... its on the way!

@jeffwecan jeffwecan added the database database secrets engine label Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database database secrets engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants