New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes to database secrets engine #457
Conversation
include mount_point doc flake8
Codecov Report
@@ Coverage Diff @@
## develop #457 +/- ##
=========================================
+ Coverage 88% 88% +<.01%
=========================================
Files 50 50
Lines 2659 2660 +1
=========================================
+ Hits 2340 2341 +1
Misses 319 319
|
@jeffwecan alright so afaik these are good to go. ive tested most of the functionality and am using them here: TerryHowe/ansible-modules-hashivault#133 if you have a chance to merge and cut a release next week that would be AWESOME! |
Sounds good, thanks again for all the contributions! I'll aim to cut a release over the next few days as I have time available. |
Absolutely. I'm looking at your unit tests trying to see if i can figure out a way to make some for this module also... havent messed with mocks much so might take me sometime but... its on the way! |
fix
delete_connection
return value. call does not return json objectinclude optional
mount_point
but default to 'database'tested:
list_connections
read_connection
configure
delete_connection
create_role
delete_role
list_roles