Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enable consul secret engine #460

Merged
merged 2 commits into from Jun 3, 2019

Conversation

Projects
None yet
3 participants
@Dudesons
Copy link
Contributor

commented Jun 3, 2019

No description provided.

@codecov-io

This comment has been minimized.

Copy link

commented Jun 3, 2019

Codecov Report

Merging #460 into develop will increase coverage by 0.34%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #460      +/-   ##
===========================================
+ Coverage       88%   88.35%   +0.34%     
===========================================
  Files           50       50              
  Lines         2660     2662       +2     
===========================================
+ Hits          2341     2352      +11     
+ Misses         319      310       -9
Impacted Files Coverage Δ
hvac/api/secrets_engines/__init__.py 100% <100%> (ø) ⬆️
hvac/api/secrets_engines/consul.py 41.66% <53.84%> (+41.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa529b7...85e59bc. Read the comment docs.

@jeffwecan
Copy link
Collaborator

left a comment

Thanks! My bad for missing the enablement piece!

@jeffwecan jeffwecan merged commit b8aa57e into hvac:develop Jun 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Dudesons Dudesons deleted the Dudesons:fix-enable-consul-secret-engine branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.