Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add P-384 and RSA-3072 to list of allowed key types #606

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Add P-384 and RSA-3072 to list of allowed key types #606

merged 2 commits into from
Jul 21, 2020

Conversation

trishankatdatadog
Copy link
Contributor

Fix #605

Signed-off-by: Trishank Karthik Kuppusamy trishank.kuppusamy@datadoghq.com

@trishankatdatadog
add P-384 and RSA-3072
fa813c4 
Signed-off-by: Trishank Karthik Kuppusamy <trishank.kuppusamy@datadoghq.com>
@trishankatdatadog trishankatdatadog requested a review from a team as a code owner July 20, 2020 22:14
@trishankatdatadog
update docstring
8d5711c 
Signed-off-by: Trishank Karthik Kuppusamy <trishank.kuppusamy@datadoghq.com>
@jeffwecan jeffwecan added enhancement a new feature or addition transit Transit secrets engine labels Jul 21, 2020
jeffwecan
jeffwecan approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@jeffwecan jeffwecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! I'm planning on generating a release later this week. So this change will go out then. 👍🏻

@jeffwecan jeffwecan merged commit 058d444 into hvac:develop Jul 21, 2020
@trishankatdatadog
Copy link
Contributor Author

Thanks, Jeff! I forgot to add P-521, so will add that soon...

@trishankatdatadog trishankatdatadog mentioned this pull request Jul 21, 2020
Merged
@jeffwecan jeffwecan added this to the 0.10.5 milestone Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffwecan jeffwecan jeffwecan approved these changes

Assignees
No one assigned
Labels
enhancement a new feature or addition transit Transit secrets engine
Projects
None yet
Milestone
0.10.5
Development

Successfully merging this pull request may close these issues.

Add support for P-384 and RSA-3072
2 participants
@trishankatdatadog @jeffwecan