Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JWT/OIDC Authentication Method Classes #613

Merged
merged 5 commits into from
Jul 26, 2020
Merged

Add JWT/OIDC Authentication Method Classes #613

merged 5 commits into from
Jul 26, 2020

Conversation

jeffwecan
Copy link
Member

@jeffwecan jeffwecan commented Jul 26, 2020 •
edited
Loading

There integration test bits with dummy OIDC provider / server is perhaps a bit much, but it was helpful having around when validating things so 🤷

Resolves #607

@jeffwecan jeffwecan added the enhancement a new feature or addition label Jul 26, 2020
@jeffwecan jeffwecan requested a review from a team as a code owner July 26, 2020 15:46
@jeffwecan jeffwecan added the jwt/oidc JWT/OIDC auth method label Jul 26, 2020
@jeffwecan jeffwecan force-pushed the jeffwecan/jwt_oidc_auth_method branch 2 times, most recently from 567ddb2 to 080094d Compare July 26, 2020 16:30
Base automatically changed from jeffwecan/identity_tokens to develop July 26, 2020 16:36
@jeffwecan jeffwecan force-pushed the jeffwecan/jwt_oidc_auth_method branch 2 times, most recently from 77e1e5d to 4bc2e51 Compare July 26, 2020 16:56
@jeffwecan jeffwecan force-pushed the jeffwecan/jwt_oidc_auth_method branch from 4bc2e51 to 514a24a Compare July 26, 2020 17:04
@jeffwecan jeffwecan force-pushed the jeffwecan/jwt_oidc_auth_method branch from 514a24a to 2e96c38 Compare July 26, 2020 17:14
@codecov
Copy link

codecov bot commented Jul 26, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@206e6b4). Click here to learn what that means.
The diff coverage is 93.61%.

@@            Coverage Diff             @@
##             develop     #613   +/-   ##
==========================================
  Coverage           ?   83.41%           
==========================================
  Files              ?       59           
  Lines              ?     3106           
  Branches           ?        0           
==========================================
  Hits               ?     2591           
  Misses             ?      515           
  Partials           ?        0
Impacted Files Coverage Δ
hvac/api/auth_methods/jwt.py 92.30% <92.30%> (ø)
hvac/api/auth_methods/__init__.py 80.00% <100.00%> (ø)
hvac/api/auth_methods/oidc.py 100.00% <100.00%> (ø)
hvac/api/secrets_engines/kv_v1.py 100.00% <0.00%> (ø)
hvac/api/secrets_engines/__init__.py 100.00% <0.00%> (ø)
hvac/api/auth_methods/github.py 100.00% <0.00%> (ø)
hvac/api/system_backend/leader.py 75.00% <0.00%> (ø)
hvac/api/auth_methods/gcp.py 89.74% <0.00%> (ø)
hvac/aws_utils.py 94.59% <0.00%> (ø)
... and 52 more

@jeffwecan jeffwecan merged commit e949d47 into develop Jul 26, 2020
@jeffwecan jeffwecan deleted the jeffwecan/jwt_oidc_auth_method branch July 26, 2020 17:44
@jeffwecan jeffwecan added this to the 0.10.5 milestone Jul 26, 2020
@jeffwecan jeffwecan mentioned this pull request Jul 26, 2020
Open
@jeffwecan
Copy link
Member Author

Also tagging ansible-collections/community.general#154 in this PR seems it seems to cover a related topic...

@briantist briantist mentioned this pull request Oct 30, 2020
Closed
@erikgb erikgb mentioned this pull request Nov 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement a new feature or addition jwt/oidc JWT/OIDC auth method
Projects
None yet
Milestone
0.10.5
Development

Successfully merging this pull request may close these issues.

Auth with OIDC
1 participant
@jeffwecan