Fix Cert.login() handling of use_token argument #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #720 +/- ##
========================================
Coverage 82.95% 82.95%
========================================
Files 62 62
Lines 3356 3356
========================================
Hits 2784 2784
Misses 572 572
|
|
Ping? @jeffwecan? |
This was referenced Jul 7, 2021
jeffwecan
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
client.auth.cert.login(use_token=True)argument should be passed internally toAdapter.login(). But instead it was sent to Vault in the POST body, which is not recognized by Vault: https://www.vaultproject.io/api/auth/cert#login-with-tls-certificate-methodRegression in #691 (7bb92f7).