Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Passing of cert Parameter From Client into Adapter Class #743

Merged
merged 2 commits into from Sep 22, 2021

Conversation

Tylerlhess
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #743 (a2739f2) into develop (5379013) will increase coverage by 0.02%.
The diff coverage is 78.57%.

@@             Coverage Diff             @@
##           develop     #743      +/-   ##
===========================================
+ Coverage    77.28%   77.31%   +0.02%     
===========================================
  Files           63       63              
  Lines         3540     3540              
===========================================
+ Hits          2736     2737       +1     
+ Misses         804      803       -1     
Impacted Files Coverage Δ
hvac/api/auth_methods/cert.py 89.83% <76.92%> (+1.49%) ⬆️
hvac/adapters.py 86.00% <100.00%> (+0.14%) ⬆️

@jeffwecan jeffwecan added the tls-cert-auth Related to TLS Certificates Auth Method label Sep 22, 2021
@jeffwecan jeffwecan changed the title Fixed issues with pr #691 as per the comments. Fix Passing of cert Parameter From Client into Adapter Class Sep 22, 2021
@jeffwecan jeffwecan added the bug label Sep 22, 2021
@jeffwecan jeffwecan added this to the 0.11.1 milestone Sep 22, 2021
@jeffwecan jeffwecan merged commit a368f9e into hvac:develop Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tls-cert-auth Related to TLS Certificates Auth Method
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants