build-test: Add test #844
Merged
build-test: Add test #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #844 +/- ##
===========================================
- Coverage 77.91% 77.61% -0.31%
===========================================
Files 64 64
Lines 3600 3600
===========================================
- Hits 2805 2794 -11
- Misses 795 806 +11
|
Adds build test to ensure hvac is always in a buildable state and can be installed on Mac, Ubuntu, and Windows. Signed-off-by: Colin McAllister <colinmca242@gmail.com>
colin-pm
force-pushed
the
feature/build_test
branch
from
796b9ed
to
7d9ed4f
Compare
|
Made a small mistake on the initial change with Python versions requiring strings so Python version 3.10 is interpreted as "3.10" and not 3.1... Made this change. As expected and pointed out in #843, the tests fail for Windows. I will still merge this as the failed tests reflect the current state of the repository. I would like to merge this change beforehand so the new tests can run for #843. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds build test to ensure hvac is always in a buildable state and can be installed on Mac, Ubuntu, and Windows.
Signed-off-by: Colin McAllister colinmca242@gmail.com