Tests: Handle different response due to upstream change #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An external group type with no populated members returns null for member_entity_ids instead of an empty list starting in Vault 1.11. The failing test that discovered this API change has been updated to handle null. Signed-off-by: Colin McAllister <colinmca242@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #876 +/- ##
===========================================
- Coverage 77.96% 77.20% -0.76%
===========================================
Files 64 64
Lines 3608 3536 -72
===========================================
- Hits 2813 2730 -83
- Misses 795 806 +11
|
briantist
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An external group type with no populated members returns null for member_entity_ids instead of an empty list starting in Vault 1.11.
The failing test that discovered this API change has been updated to handle null.
This closes #862 if no other solution is identified upstream in hashicorp/vault#17107
Signed-off-by: Colin McAllister colinmca242@gmail.com