Skip to content

Commit

Permalink
Revert applyDefaults introduced via new-install & new-update
Browse files Browse the repository at this point in the history
  • Loading branch information
hvr committed Feb 8, 2018
1 parent e7445f0 commit 45b7334
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
6 changes: 2 additions & 4 deletions cabal-install/Distribution/Client/CmdInstall.hs
Expand Up @@ -21,8 +21,7 @@ import Distribution.Client.ProjectOrchestration
import Distribution.Client.CmdErrorMessages

import Distribution.Client.Setup
( GlobalFlags, ConfigFlags(..), ConfigExFlags, InstallFlags
, applyFlagDefaults )
( GlobalFlags, ConfigFlags(..), ConfigExFlags, InstallFlags )
import qualified Distribution.Client.Setup as Client
import Distribution.Client.Types
( PackageSpecifier(NamedPackage), UnresolvedSourcePackage )
Expand Down Expand Up @@ -119,8 +118,7 @@ installCommand = CommandUI
--
installAction :: (ConfigFlags, ConfigExFlags, InstallFlags, HaddockFlags)
-> [String] -> GlobalFlags -> IO ()
installAction (applyFlagDefaults ->
(configFlags, configExFlags, installFlags, haddockFlags))
installAction (configFlags, configExFlags, installFlags, haddockFlags)
targetStrings globalFlags = do
-- We never try to build tests/benchmarks for remote packages.
-- So we set them as disabled by default and error if they are explicitly
Expand Down
5 changes: 2 additions & 3 deletions cabal-install/Distribution/Client/CmdUpdate.hs
Expand Up @@ -24,7 +24,7 @@ import Distribution.Client.JobControl
( newParallelJobControl, spawnJob, collectJob )
import Distribution.Client.Setup
( GlobalFlags, ConfigFlags(..), ConfigExFlags, InstallFlags
, UpdateFlags, applyFlagDefaults, defaultUpdateFlags
, UpdateFlags, defaultUpdateFlags
, RepoContext(..) )
import Distribution.Simple.Setup
( HaddockFlags, fromFlagOrDefault )
Expand Down Expand Up @@ -107,8 +107,7 @@ instance Text UpdateRequest where

updateAction :: (ConfigFlags, ConfigExFlags, InstallFlags, HaddockFlags)
-> [String] -> GlobalFlags -> IO ()
updateAction (applyFlagDefaults -> ( configFlags, configExFlags
, installFlags, haddockFlags ))
updateAction (configFlags, configExFlags, installFlags, haddockFlags)
extraArgs globalFlags = do

ProjectBaseContext {
Expand Down

0 comments on commit 45b7334

Please sign in to comment.