Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT actions not processed after commit 888a1d2 (Return the result of commands via MQTT if the caller specified a response) #23

Closed
SenH opened this issue Oct 17, 2023 · 2 comments

Comments

@SenH
Copy link
Contributor

SenH commented Oct 17, 2023

My broker is Mosquito (MQTTv3.1.1 - protocol 4). The actions are not received in the mqttaction procedure from commit 888a1d2. The previous commit 4cb8364 is OK.

This patch seems to fix my issue (but it will break MQTTv5):

-proc mqttaction {topic data retain props args} {
+proc mqttaction {topic data retain {props {}}} {
@SenH SenH changed the title MQTT actions not processed after commit 888a1d2df87997e9b3bb805c858889f3c2d6a58b MQTT actions not processed after commit 888a1d2 (Return the result of commands via MQTT if the caller specified a response) Oct 17, 2023
@dhannema
Copy link

@SenH Thanks, this indeed fixes the MQTT bug for now 👍

hvxl added a commit that referenced this issue Oct 22, 2023
@hvxl
Copy link
Owner

hvxl commented Oct 22, 2023

This patch seems to fix my issue (but it will break MQTTv5):

That patch is perfectly fine for MQTTv5 as well. I just like to be prepared for possible future additions of more arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants