Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csi-node-driver-registrar is from k8s.gcr.io #46

Closed
yankay opened this issue Jun 21, 2022 · 3 comments
Closed

csi-node-driver-registrar is from k8s.gcr.io #46

yankay opened this issue Jun 21, 2022 · 3 comments
Assignees
Labels

Comments

@yankay
Copy link
Member

yankay commented Jun 21, 2022

According to the docs : https://kubernetes-csi.github.io/docs/node-driver-registrar.html, csi-node-driver-registrar is from k8s.gcr.io. But the is from the https://github.com/hwameistor/helm-charts/blob/main/charts/hwameistor/values.yaml#L1, It's from the Quay.io .

@SSmallMonster SSmallMonster self-assigned this Jun 22, 2022
@SSmallMonster
Copy link
Member

Hi, @yankay
Thanks for your suggestion.

The registry of the CSI controller images can be modified by specifying the value of the k8simageregistry parameter when deploy with helm.

Why we set qury.io default

qury.io will be faster than k8s.gcr.io in China , but as the default, maybe we should point it to k8s.gcr.io.

The next, we will update the default CSI controller images registry to k8s.gcr.io

@SSmallMonster SSmallMonster transferred this issue from another repository Jul 14, 2022
angel0507 added a commit to angel0507/hwameistor that referenced this issue Jul 18, 2022
Signed-off-by: jie.li <jie.li@daocloud.io>
@SSmallMonster
Copy link
Member

We encountered a problem when modifying the image repository. The CSI node driver register image was migrated from version v2.0.0 to k8s.gcr. io, but the image has not been migrated before(e.x. v1.1.0 we now use), and it still exists in qury.io

If we upgrade the version directly, may face some compatibility problems, and we may need more tests.

@github-actions
Copy link

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants