modify pvc-autoresizer #1120
modify pvc-autoresizer #1120
Conversation
Signed-off-by: buffalo1024 <yikaichen@yikaichendeMacBook-Pro.local>
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #1120 +/- ##
==========================================
- Coverage 39.96% 39.39% -0.58%
==========================================
Files 25 25
Lines 1909 1942 +33
==========================================
+ Hits 763 765 +2
- Misses 1045 1075 +30
- Partials 101 102 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| log.Errorf("match pvc err: %v", err) | ||
| return false, err | ||
| } | ||
| if !matched { |
There was a problem hiding this comment.
why return false? should it continue to be checked more?
should it return true if matched?
There was a problem hiding this comment.
it's && relation between selectors of a resizepolicy, so if one selector doesn't match, the whole resizepolicy doesn't match.
|
In this solution, once a PVC gets updated, it will be checked against the policy and associated with a policy if matched. In case, user wants to disable auto resize for a PVC, how to handle it? |
to disable autoresizing for a pvc, keep that no resizepolicy select the pvc. |
What this PR does / why we need it:
Special notes for your reviewer:
Does this PR introduce a user-facing change?