stop mount process when duplicate device link found #1131
Conversation
SSmallMonster
force-pushed
the
fix-1116
branch
from
e424441
to
3baf607
Compare
| } | ||
|
|
||
| var matchedDevices []manager.Attribute | ||
| for i, device := range allDevices { |
There was a problem hiding this comment.
Maybe we can add serial number to ldv status, and you can match serial number here. It's right if there is only one device whose serial number match ldv's serial number.
There was a problem hiding this comment.
add serial number in the status may be another topic.
in my opinion the essence of this PR fix is errors that may be caused by duplicate devlink. Finding whether devlink is duplicated may be more direct and effective than serial, although in most cases this link is generated by serial, I am not sure if there are inequality situations in some special scenarios.
Signed-off-by: SSmallMonster <mingming.zhou@daocloud.io>
Signed-off-by: SSmallMonster <mingming.zhou@daocloud.io>
SSmallMonster
force-pushed
the
fix-1116
branch
from
3baf607
to
96fb90d
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #1131 +/- ##
==========================================
- Coverage 39.39% 38.83% -0.56%
==========================================
Files 25 25
Lines 1942 1970 +28
==========================================
Hits 765 765
- Misses 1075 1103 +28
Partials 102 102
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
What this PR does / why we need it:
fix #1116
Special notes for your reviewer:
Does this PR introduce a user-facing change?