Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct safelyMount check #1165

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

SSmallMonster
Copy link
Member

@SSmallMonster SSmallMonster commented Oct 8, 2023

What this PR does / why we need it:

  • do not output the trailing delimiter when readlink
  • split volume path correctly

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@codecov-commenter
Copy link

Codecov Report

Merging #1165 (4abcc8b) into main (0f00a8c) will increase coverage by 0.15%.
Report is 4 commits behind head on main.
The diff coverage is 57.14%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #1165      +/-   ##
==========================================
+ Coverage   38.83%   38.98%   +0.15%     
==========================================
  Files          25       25              
  Lines        1970     1980      +10     
==========================================
+ Hits          765      772       +7     
- Misses       1103     1106       +3     
  Partials      102      102              
Files Coverage Δ
...k-manager/handler/localdiskclaim/localdiskclaim.go 69.23% <100.00%> (ø)
pkg/local-disk-manager/filter/filter_disk.go 51.66% <70.00%> (+1.66%) ⬆️
...manager/handler/localdiskvolume/localdiskvolume.go 7.97% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SSmallMonster SSmallMonster added the kind/bug Categorizes issue or PR as related to a bug. label Oct 8, 2023
- do not output the trailing delimiter when readlink
- split volume path correctly

Signed-off-by: SSmallMonster <mingming.zhou@daocloud.io>
@SSmallMonster SSmallMonster merged commit ca73250 into hwameistor:main Oct 8, 2023
1 of 3 checks passed
@SSmallMonster SSmallMonster deleted the fix-diskvolume-mount branch October 9, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants