optimize datacopy job name generating #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: buffalo1024 <yikaichen@yikaichendeMacBook-Pro.local>
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #1196 +/- ##
=======================================
Coverage 38.13% 38.13%
=======================================
Files 25 25
Lines 1980 1980
=======================================
Hits 755 755
Misses 1125 1125
Partials 100 100 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -448,5 +449,21 @@ func generateJobName(mName string, pvcName string) string { | |||
| if len(pvcName) > 25 { | |||
| pvcName = pvcName[:25] | |||
| } | |||
| return fmt.Sprintf("%s-datacopy-%s", mName, pvcName) | |||
| jobName := fmt.Sprintf("%s-datacopy-%s", mName, pvcName) | |||
There was a problem hiding this comment.
what does this name %s-datacopy-%s mean and what's releationship with LocalVolumeMigrate and LocalVolume?
maybe the name of LocalVoumeMigrate is enough for the datacopy job?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
generated jobname end with character "-" is invalid against RFC 1123 subdomain while creating job
Special notes for your reviewer:
Does this PR introduce a user-facing change?