fix(apiserver): filter VolumeState when list replicas #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #1202 +/- ##
=======================================
Coverage 35.81% 35.81%
=======================================
Files 28 28
Lines 2178 2178
=======================================
Hits 780 780
Misses 1295 1295
Partials 103 103 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hikariwo
force-pushed
the
main
branch
2 times, most recently
from
20b3cea
to
bb2d6b5
Compare
Signed-off-by: lancerxiu <1377004871@qq.com>
hikariwo
changed the title
|
@peng9808 can you take a look? I am not sure if |
SSmallMonster
changed the title
|
@peng9808 would you like to review this PR? |
|
@SSmallMonster VolumeState is used in our front code |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fix #1200
Special notes for your reviewer:
Does this PR introduce a user-facing change?