Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(local-storage): potential data race in registry #1238

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

hikariwo
Copy link
Member

What this PR does / why we need it:

fix #1237

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Signed-off-by: lancerxiu <1377004871@qq.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1238 (27aa4c4) into main (c0e1d64) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main    #1238   +/-   ##
=======================================
  Coverage   35.77%   35.77%           
=======================================
  Files          28       28           
  Lines        2180     2180           
=======================================
  Hits          780      780           
  Misses       1297     1297           
  Partials      103      103           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@SSmallMonster
Copy link
Member

lgtm!

btw, have you ever encountered an error that was affected by this?

@SSmallMonster SSmallMonster added the kind/bug Categorizes issue or PR as related to a bug. label Nov 13, 2023
@hikariwo
Copy link
Member Author

lgtm!

btw, have you ever encountered an error that was affected by this?

I have met this problem from the MIT6.824 course labs. It explains the data race problem making the routine unpredictable and the log unreliable. Maybe this problem are not so serious in an environment having a few conflicts, but the problem will be more complicated when the race happens with other bug.

@SSmallMonster
Copy link
Member

lgtm!
btw, have you ever encountered an error that was affected by this?

I have met this problem from the MIT6.824 course labs. It explains the data race problem making the routine unpredictable and the log unreliable. Maybe this problem are not so serious in an environment having a few conflicts, but the problem will be more complicated when the race happens with other bug.

under

lgtm!
btw, have you ever encountered an error that was affected by this?

I have met this problem from the MIT6.824 course labs. It explains the data race problem making the routine unpredictable and the log unreliable. Maybe this problem are not so serious in an environment having a few conflicts, but the problem will be more complicated when the race happens with other bug.

got, i was wondering if any error already occured by this, anyway good catch!

@SSmallMonster SSmallMonster merged commit 373e6b9 into hwameistor:main Nov 14, 2023
3 checks passed
@hikariwo hikariwo deleted the fix-data-race branch November 14, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LocalStorage: potential data race in using registry data
3 participants