Migrate #1239
Merged
Migrate #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1239 +/- ##
=======================================
Coverage 35.77% 35.77%
=======================================
Files 28 28
Lines 2180 2180
=======================================
Hits 780 780
Misses 1297 1297
Partials 103 103 ☔ View full report in Codecov by Sentry. |
SSmallMonster
requested changes
Nov 14, 2023
| VolumeMigrateCompletedAnnoKey = "hwameistor.io/volume-migrate-completed" | ||
| MigrateRunning = "migrateRunning" | ||
| MigrateFinish = "migrateFinish" | ||
| ) |
There was a problem hiding this comment.
suggest values: started, completed
Comment on lines
151
to
165
| ////Determine if there is a migration operation | ||
| //if replica.Status.State != apisv1alpha1.VolumeReplicaStateReady { | ||
| // ctx := context.TODO() | ||
| // volName := replica.Spec.VolumeName | ||
| // lvmName := fmt.Sprintf("evictor-%s", volName) | ||
| // lvMigrate := &apisv1alpha1.LocalVolumeMigrate{} | ||
| // if err = m.apiClient.Get(ctx, types.NamespacedName{Namespace: m.namespace, Name: lvmName}, lvMigrate); err != nil { | ||
| // if !errors.IsNotFound(err) { | ||
| // return err | ||
| // } | ||
| // } else { | ||
| // testReplica.Status.State = apisv1alpha1.VolumeReplicaStateNotReady | ||
| // } | ||
| //} | ||
|
|
pkg/local-storage/member/controller/volume_migrate_task_worker.go
Outdated
Show resolved
Hide resolved
Signed-off-by: peng9808 <peng.lai@daocloud.io>
SSmallMonster
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#1228
#1213
Special notes for your reviewer:
Logical judgment of lvr state change with migration
Does this PR introduce a user-facing change?
NONE